Getting started with development¶
This document assumes you want to run the current latest Plone source, fix a bug in Plone, or test an addon in the context of the latest code, and will detail the full process. For more information on writing PLIPS, please go here.
Version Support Policy¶
If you are triaging or fixing bugs, keep in mind that Plone has a version support policy.
- Python 2.7 including development headers.
- If you are on Mac OSX, you will need to install XCode. You can do this through the app store or several other soul-selling methods. You will likely want to install your own python 2.6 as well since they strip out all the header files which makes compiling some extensions weird. You can ignore this advice to start, but have faith, you’ll come back to it later. They always do…
- Python Imaging Library (PIL). Make sure to install this into the proper python environment.
- VirtualEnv in the proper python environment.
- GCC in order to compile ZODB, Zope and lxml.
- libxml2 and libxslt, including development headers.
Setting up Your Development Environment¶
The first step in fixing a bug is getting this buildout running. We recommend fixing the bug on the latest branch and then backporting as necessary. GitHub by default always points to the currently active branch. More information on switching release branches is below.
To set up a plone 5 development environment:
> cd ~/buildouts # or wherever you want to put things > git clone -b 5.0 https://github.com/plone/buildout.coredev ./plone5devel > virtualenv --no-site-packages plone5devpy > cd plone5devel > ../plone5devpy/bin/pip install -r requirements.txt > ../plone5devpy/bin/buildout bootstrap > bin/buildout -v
If you run into issues in this process, please see the doc Troubleshooting.
This will run for a long time if it is your first pull (~20 mins). Once that is done pulling down eggs, you can start your new instance with:
> ./bin/instance fg
The default username/password for a dev instance is admin/admin.
If your bug is specific to one branch or you think it should be backported, you can easily switch branches. The first time you get a branch, you must do:
> git checkout -t origin/4.1
This should set up a local 4.1 branch tracking the one on GitHub. From then on you can just do:
> git checkout 4.1
To see what branch you are currently on, just do:
> git branch
The line with a * by it will indicate which branch you are currently working on.
Make sure to rerun buildout if you were in a different branch earlier to get the correct versions of packages, otherwise you will get some weird behavior!
Jenkins / mr.roboto¶
Plone has a Continuous Integration setup and follows CI rules.
When you push a change to any Plone core package,
our testing/CI middleware
mr.roboto starts running all the tests that are needed to make sure that you don’t break anything.
For each Plone and Python version we run two jobs,
one for the package itself (which will give you a fast feedback, within 10 minutes)
and one on the full coredev build (which can take up until an hour,
but makes sure no other packages are effected by your change.
The CI system at jenkins.plone.org is a shared resource for Plone core developers to notify them of regressions in Plone core code. Build breakages are a normal and expected part of the development process. Our aim is to find errors and eliminate them as quickly as possible, without expecting perfection and zero errors. Though, there are some essential practices that needs to be followed in order to achieve a stable build:
- Don’t Check In on a Broken Build - check Jenkins before
- Always Run All Commit Tests Locally before Committing
- Wait for Commit Tests to Pass before Moving On
- Never Go Home on a Broken Build
- Always Be Prepared to Revert to the Previous Revision
- Time-Box Fixing before Reverting
- Don’t Comment Out Failing Tests
- Take Responsibility for All Breakages That Result from Your Changes
See Essential Continuous Integration Practices for more information.
Since it can be burdensome to check this manually, install yourself the tools to always see the current state of the Plone CI Server:
- For (Ubuntu?) Linux there is BuildNotify.
- For Mac there is CCMenu.
- For windows there is CCTray.
- For Firefox there is CruiseControl Monitor and many other jenkins specific plugins.
These tools were built to parse a specific file that CruiseControl another CI tool generated.
Jenkins generates this file too.
You want to configure your notifier of choice with this url:
Checking out Packages for Fixing¶
Most packages are not in
src/ by default,
so you can use
mr.developer to get the latest and make sure you are always up to date.
It can be a little daunting at first to find out which packages are causing the bug in question,
but just ask on irc if you need some help.
Once you [think you] know which package(s) you want,
we need to pull the source.
You can get the source of the package with
mr.developer and the checkout command,
or you can go directly to editing
We recommend the latter but will describe both.
In the end,
checkouts.cfg must be configured either way so you might as well start there.
At the base of your buildout,
checkouts.cfg and add your package if it’s not already there:
auto-checkout = # my modified packages plone.app.caching plone.caching # others ...
Then rerun buildout to get the source packages:
we can manage checkouts from the command line,
by using mr.developer’s bin/develop command to get the latest source.
if the issue is in
> ./bin/develop co plone.app.caching > ./bin/develop co plone.caching > ./bin/buildout
Don’t forget to rerun buildout!
In both methods,
mr.developer will download the source from GitHub (or otherwise) and put the package in the
You can repeat this process with as many or as few packages as you need.
For some more tips on working with
please read more here.
To run a test for the specific module you are modifying:
> ./bin/test -m plone.app.caching
These should all run without error. Please don’t check in anything that doesn’t! Now write a test case for the bug you are fixing and make sure everything is running as it should.
After the module level tests run with your change, please make sure other modules aren’t affected by the change by running the full suite:
Tests take a long time to run. Once you become a master of bugfixes, you may just let jenkins do this part for you. More on that below.
Updating CHANGES.rst and checkouts.cfg¶
Once all the tests are running locally on your machine, you are ALMOST ready to commit the changes. A couple housekeeping things before moving on.
HISTORY.txt) in each package you have modified and add a summary of the change.
This change note will be collated for the next Plone release and is important for integrators and developers to be able to see what they will get if they upgrade.
New changelog entries should be added at the very top of
if you didn’t do it earlier,
checkouts.cfg file in the buildout directory and add your changes package to the
This lets the release manager know that the package has been updated,
so that when the next release of Plone is cut,
a new egg will be released and Plone will need to pin to the next version of that package.
READ: this is how your fix becomes an egg!
Note that there is a section separator called “# Test Fixes Only”. Make sure your egg is above that line or your egg probably won’t get made very quickly. This just tells the release manager that any eggs below this line have tests that are updated, but no code changes.
checkouts.cfg file also triggers the buildbot,
jenkins, to pull in the egg and run all the tests against the changes you just made.
Not that you would ever skip running all tests of course…
More on that below.
If your bug is in more than one release (e.g. 4.1 and 4.2),
please checkout both branches and add to the
Committing and Pull Requests¶
Phew! We are in the home stretch. How about a last minute checklist:
- Did you fix the original bug?
- Is your code consistent with our /develop/styleguide/index?
- Did you remove any extra code and lingering pdbs?
- Did you write a test case for that bug?
- Are all test cases for the modules(s) and for Plone passing?
- Did you update
CHANGES.rstin each packages you touched?
- Did you add your changed packages to
If you answered YES to all of these questions, you are ready to push your changes! A couple quick reminders:
- Only commit directly to the development branch if you’re confident your code won’t break anything badly and the changes are small and fairly trivial. Otherwise, please create a
pull request(more on that below).
- Please try to make one change per commit. If you are fixing three bugs, make three commits. That way, it is easier to see what was done when, and easier to
roll backany changes if necessary. If you want to make large changes cleaning up whitespace or renaming variables, it is especially important to do so in a separate commit for this reason.
- We have a few angels that follow the changes and each commit to see what happens to their favourite CMS! If you commit something REALLY sketchy, they will politely contact you, most likely after immediately reverting changes. There is no official people assigned to this so if you are especially nervous, jump into #plone and ask for a quick eyeball on your changes.
Committing to Products.CMFPlone¶
If you are working a bug fix on
there are a couple other things to take notice of.
First and foremost,
you’ll see that there are several branches.
At the time of writing this document,
there are branches for 4.2.x, 4.3.x and master,
which is the implied 5.0.
This may change faster than this documentation,
so check the branch dropdown on GitHub.
Still with me? So you have a bug fix for 4.x. If the fix is only for one version, make sure to get that branch and party on. However, chances are the bug is in multiple branches.
Let’s say the bug starts in 4.1. Pull the 4.1 branch and fix and commit there with tests.
If your fix only involved a single commit,
you can use git’s
cherry-pick command to apply the same commit to a different branch.
First check out the branch:
> git checkout 4.2
cherry-pick the commit (you can get the SHA hash from git log).:
> git cherry-pick b6ff4309
There may be conflicts;
resolve them and then follow the directions git gives you to complete the
If your fix involved multiple commits,
cherry-picking them one by one can get tedious.
In this case things are easiest if you did your fix in a separate feature branch.
In that scenario, you first merge the feature branch to the 4.1 branch:
> git checkout 4.1 > git merge my-awesome-feature
Then you return to the feature branch and make a branch for rebasing it onto the 4.2 branch:
> git checkout my-awesome-feature > git checkout -b my-awesome-feature-4.2 > git rebase ef978a --onto 4.2
(ef978a happens to be the last commit in the feature branch’s history before it was branched off of 4.1. You can look at git log to find this.)
At this point, the feature branch’s history has been updated, but it hasn’t actually been merged to 4.2 yet. This lets you deal with resolving conflicts before you actually merge it to the 4.2 release branch. Let’s do that now:
> git checkout 4.2 > git merge my-awesome-feature-4.2
Branches and Forks and Direct Commits - Oh My!¶
Plone used to be in an svn repository,
so everyone is familiar and accustomed to committing directly to the branches.
After the migration to GitHub,
the community decided to maintain this spirit.
If you have signed the contributor agreement form,
you can commit directly to the branch
(for plone this would be the version branch, for most other packages this would be
HOWEVER, there are a few situations where a branch is appropriate. If you:
- are just getting started,
- are not sure about your changes
- want feedback/code review
- are implementing a non-trivial change
then you likely want to create a branch of whatever packages you are using and then use the pull request feature of GitHub to get review.
Everything about this process would be the same except you need to work on a branch.
After checking it out with
create your own branch with:
> cd src/plone.app.caching > git checkout -b my_descriptive_branch_name
Branching or forking is your choice. I prefer branching, and I’m writing the docs so this uses the branch method. If you branch, it helps us because we know that you have committer rights. Either way it’s your call.
Proceed as normal.
When you are ready to
push your fix,
push to a remote branch with:
> git push origin my_descriptive_branch_name
This will make a remote branch in GitHub.
Navigate to this branch in the GitHub UI and on the top right there will be a button that says “Pull Request”.
This will turn your request into a pull request on the main branch.
There are people who look once a week or more for pending pull requests and will confirm whether or not its a good fix and give you feedback where necessary.
The reviewers are informal and very nice so don’t worry - they are there to help!
If you want immediate feedback,
jump into IRC with the
pull request link and ask for a review.
You still need to update
checkouts.cfg file in the correct branches of buildout.coredev!
If you are working from a ticket, please don’t forget to go back to the ticket and add a link to the changeset. We don’t have integration with GitHub yet so it’s a nice way to track changes. It also lets the reporter know that you care. If the bug is really bad, consider pinging the release manager and asking him to make a release pronto.